Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rapids_cpm_cccl use proper CCCL version value to compute install rules #742

Merged
merged 2 commits into from
Jan 16, 2025
Merged

rapids_cpm_cccl use proper CCCL version value to compute install rules #742

merged 2 commits into from
Jan 16, 2025

Conversation

robertmaynard
Copy link
Contributor

Description

We can't use the request versions.json version value as it might be 2.7 and we found >= 2.8

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

@robertmaynard robertmaynard added the bug Something isn't working label Jan 13, 2025
@robertmaynard robertmaynard requested a review from a team as a code owner January 13, 2025 17:00
@robertmaynard robertmaynard added the non-breaking Introduces a non-breaking change label Jan 13, 2025
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit fa580e5 into rapidsai:branch-25.02 Jan 16, 2025
16 checks passed
@robertmaynard robertmaynard deleted the bug/use_cccl_version_for_install_rules_checks branch January 16, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertmaynard @bdice